Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: display new warnings in stdcm #9314

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Oct 11, 2024

closes #9299

Display a warning if the infra is loading or if the user launches a request when some waypoints do not have a location

@clarani clarani requested a review from a team as a code owner October 11, 2024 13:25
@clarani clarani force-pushed the cni/9299-display-warning-during-infra-load branch from 1763359 to 35da5a4 Compare October 11, 2024 13:26
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 67 lines in your changes missing coverage. Please review.

Project coverage is 39.14%. Comparing base (665e2b6) to head (943acc3).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...rc/applications/stdcmV2/components/StdcmConfig.tsx 0.00% 31 Missing ⚠️
...plications/stdcmV2/utils/checkStdcmConfigErrors.ts 0.00% 15 Missing and 1 partial ⚠️
...pplications/stdcmV2/components/StdcmWarningBox.tsx 0.00% 13 Missing ⚠️
front/scripts/i18n-checker.ts 0.00% 5 Missing ⚠️
...applications/stdcmV2/hooks/useStaticPathfinding.ts 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9314      +/-   ##
============================================
- Coverage     39.17%   39.14%   -0.03%     
  Complexity     2245     2245              
============================================
  Files          1290     1290              
  Lines         97241    97282      +41     
  Branches       3280     3280              
============================================
- Hits          38093    38083      -10     
- Misses        57209    57260      +51     
  Partials       1939     1939              
Flag Coverage Δ
core 74.94% <ø> (ø)
editoast 72.39% <ø> (-0.04%) ⬇️
front 10.33% <0.00%> (-0.01%) ⬇️
gateway 2.50% <ø> (ø)
osrdyne 3.52% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clarani clarani force-pushed the cni/9299-display-warning-during-infra-load branch 2 times, most recently from c3664ff to f2e834f Compare October 11, 2024 14:08
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested

Display a warning if the infra is loading or if the user launches a request when some waypoints do not have a location

Signed-off-by: Clara Ni <[email protected]>
@clarani clarani force-pushed the cni/9299-display-warning-during-infra-load branch from f54c9f2 to 943acc3 Compare October 11, 2024 15:44
@clarani clarani added this pull request to the merge queue Oct 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 11, 2024
@SharglutDev SharglutDev added this pull request to the merge queue Oct 11, 2024
Merged via the queue into dev with commit 7a70d95 Oct 11, 2024
24 checks passed
@SharglutDev SharglutDev deleted the cni/9299-display-warning-during-infra-load branch October 11, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display infra loading in STDCM
4 participants