Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EBICAB rendering #46

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

HedgiePT
Copy link

This adds EBICAB rendering (both 700 and 900) to the Signals map.

@DerDakon
Copy link
Contributor

This needs a similar entry to the legend, which is sadly in the other repo.

@HedgiePT
Copy link
Author

HedgiePT commented Jan 26, 2021

This needs a similar entry to the legend, which is sadly in the other repo.

Added in pull request OpenRailwayMap/OpenRailwayMap#703

@HedgiePT
Copy link
Author

For testing you can use this whole route: https://www.openstreetmap.org/relation/2355657

@mmoll
Copy link
Contributor

mmoll commented Oct 2, 2021

Needs at least:

diff --git a/signals.mml b/signals.mml
index d690324..597bb28 100644
--- a/signals.mml
+++ b/signals.mml
@@ -136,7 +136,7 @@ Layer:
             NULL AS construction_usage, NULL AS construction_service,
             NULL AS preserved_railway, NULL AS preserved_service,
             NULL AS preserved_usage,
-            pzb, lzb, atb, atb_eg, atb_ng, atb_vv, etcs, construction_etcs,
+            pzb, lzb, atb, atb_eg, atb_ng, atb_vv, ebicab, etcs, construction_etcs,
             railway_train_protection_rank(pzb, lzb, atb, atb_eg, atb_ng, atb_vv, etcs, construction_etcs) AS rank
           FROM
             (SELECT
@@ -147,6 +147,7 @@ Layer:
                 tags->'railway:atb-eg' AS atb_eg,
                 tags->'railway:atb-ng' AS atb_ng,
                 tags->'railway:atb-vv' AS atb_vv,
+                tags->'railway:ebicab' AS ebicab,
                 railway_etcs_null_no(tags->'railway:etcs') AS etcs,
                 railway_etcs_null_no(tags->'construction:railway:etcs') AS construction_etcs
               FROM openrailwaymap_osm_line
@@ -173,7 +174,7 @@ Layer:
             construction_usage, construction_service,
             preserved_railway, preserved_service,
             preserved_usage,
-            pzb, lzb, atb, atb_eg, atb_ng, atb_vv, etcs, construction_etcs,
+            pzb, lzb, atb, atb_eg, atb_ng, atb_vv, ebicab, etcs, construction_etcs,
             railway_train_protection_rank(pzb, lzb, atb, atb_eg, atb_ng, atb_vv, etcs, construction_etcs) AS rank
           FROM
             (SELECT
@@ -191,6 +192,7 @@ Layer:
                 tags->'railway:atb-eg' AS atb_eg,
                 tags->'railway:atb-ng' AS atb_ng,
                 tags->'railway:atb-vv' AS atb_vv,
+                tags->'railway:ebicab' AS ebicab,
                 railway_etcs_null_no(tags->'railway:etcs') AS etcs,
                 railway_etcs_null_no(tags->'construction:railway:etcs') AS construction_etcs,
                 layer

Perhaps even more.

Also, The track in Portugal is rendered correctly with this, but nothing in the Scandinavic countries, I guess that's because of the unresolved discussion about tagging in OSM?

@davide84
Copy link
Contributor

davide84 commented Jul 4, 2023

For testing you can use this whole route: https://www.openstreetmap.org/relation/2355657

Hi! This line is currently rendered as "ATC", together with scandinavian lines. Is this PR still actual, or the label ATC has incorporated the proposed EBICAB?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants