Code

Fix: Machine is a God class#393

Code

Merged

maximilien-noal merged 25 commits intomasterOpenRakis/Spice86:masterfrom fix/godOpenRakis/Spice86:fix/godCopy head branch name to clipboardAug 2, 2023

+1,113-911

Commits

Commits on Aug 2, 2023

• Machine: RecordData is a read-only property

  Show description for a81a8c2
  maximilien-noal

  committed
  a81a8c2

• Machine: most devices don't depend on it anymore

  Show description for 6471d7c
  maximilien-noal

  committed
  6471d7c

• ModRM: no references to the Machine

  Show description for 2ac97ee
  maximilien-noal

  committed
  2ac97ee

• CPU, MachineBreakpoints, ExecutionFlowRecorder, FunctionHandler: no refs to Machine

  Show description for ac703bc
  maximilien-noal

  committed
  ac703bc

• EXE/COM/BIOS loaders: no refs to Machine

  Show description for 546a057
  maximilien-noal

  committed
  546a057

• GDB, ExecutionFlowRecoder, GhidraSymbolsDumper, RecorderDataWriter: no refs to Machine

  Show description for bb5d77b
  maximilien-noal

  committed
  bb5d77b

• SoundBlaster: no references to Machine

  Show description for b84e414
  maximilien-noal

  committed
  b84e414

• Machine: don't pass Cpu.State, only Cpu

  Show description for 3f2f58a
  maximilien-noal

  committed
  3f2f58a

• MachineBreakpoints: removed unused IGui ctor parameter

  Show description for a978e51
  maximilien-noal

  committed
  a978e51

• CPU: removed MachineBreakpoints cyclic dependency

  Show description for c777746
  maximilien-noal

  committed
  c777746

• CPU: removed IOPortDispatcher cyclic dependency

  Show description for 7f8e9bc
  maximilien-noal

  committed
  7f8e9bc

• CPU: removed DualPic cyclic dependency

  Show description for d4c0349
  maximilien-noal

  committed
  d4c0349

• CPU: removed CallbackHandler cyclic dependency

  Show description for ac86aa6
  maximilien-noal

  committed
  ac86aa6

• SoundBlaster: simplified ctor

  Show description for 13f03d5
  maximilien-noal

  committed
  13f03d5

• DefaultIOPotHandler: doesn't require Cpu nor Memory

  Show description for 0535145
  maximilien-noal

  committed
  0535145

• RecordDataWriter: Only ask for CPU state

  Show description for 433fc8a
  maximilien-noal

  committed
  433fc8a

• fix: Pass Cpu.FunctionHandler, not Cpu.FunctionHandlerInUse

  Show description for 447401a
  maximilien-noal

  committed
  447401a

• Machine: BiosDataArea is in fact read-only

  Show description for c0b6e44
  maximilien-noal

  committed
  c0b6e44

• Machine: moved emulation loop to another class

  Show description for 0276179
  maximilien-noal

  committed
  0276179

• UI: No reference to Machine

  Show description for 777ec73
  maximilien-noal

  committed
  777ec73

• UI: close debug windows on emulator restart

  Show description for 9378c64
  maximilien-noal

  committed
  9378c64

• fix: Pause

  Show description for edc7daf
  maximilien-noal

  committed
  edc7daf

• Exceptions; remove additional ctors

  Show description for 31ef815
  maximilien-noal

  committed
  31ef815

• EmulationLoop: removed Debugger.IsAttached try/catch case

  Show description for 707e221
  maximilien-noal

  committed
  707e221

• Mouse: _dualPic is readonly

  Show description for da04a16
  maximilien-noal

  committed
  da04a16