Add Bios INT 12h to report installed memory size. #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is exactly the kind of code that has been piling up in fix/detroit. I approve ! Lots of small DOS / BIOS interrupt handlers are missing, and this is one of them. (Dune is a very relaxed game on that front :D ) |
maximilien-noal
approved these changes
Jan 22, 2024
| @@ -200,7 +205,9 @@ public sealed class Machine : IDisposable, IDebuggableComponent { | |||
| Memory.UInt16[0xF000, 0xFFF0] = 0xF4; | |||
| } | |||
| IoPortDispatcher = ioPortDispatcher; | |||
| BiosDataArea = new BiosDataArea(Memory); | |||
| BiosDataArea = new BiosDataArea(Memory) { | |||
| MemSizeKb = (ushort)Math.Clamp(Memory.Ram.Size / 1024, 0, 1024) // max 1mb. | |||
There was a problem hiding this comment.
Looks like this is not supposed to include ram above 640k
http://www.techhelpmanual.com/184-int_12h__conventional_memory_size.html
0x280
There was a problem hiding this comment.
Thanks, fixed.
My source only said to use other interrupts for memory above 1mb. 640K makes more sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Add Bios INT 12h to report installed memory size.
Rationale behind Changes
#212 mentioned a game using it and we didn't have it yet.