Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to the file macros.vm in module.properties #104

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

sebastian-berlin-wmse
Copy link
Contributor

@sebastian-berlin-wmse sebastian-berlin-wmse commented Jun 4, 2024

This was causing errors when loading the extension because the file didn't exist.

Fixes: #101

This was causing errors when loading the extension because the file didn't
exist.

Fixes: OpenRefine#101
@sebastian-berlin-wmse
Copy link
Contributor Author

This also fixes #120 and OpenRefine/OpenRefine#6581. Not sure if and how I should refer to them in the commit message.

Copy link
Member

@wetneb wetneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I think it would be worth updating the OpenRefine version in pom.xml and releasing a new version of the extension after that (assuming everything works well).

@wetneb wetneb merged commit eac15b2 into OpenRefine:master Jun 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Commons extension disappears for some users when upgrading to OpenRefine 3.7.8
2 participants