Bump org.openrefine:main from 3.6-SNAPSHOT to 3.8.1 #107
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [org.openrefine:main](https://github.com/OpenRefine/OpenRefine) from 3.6-SNAPSHOT to 3.8.1. - [Release notes](https://github.com/OpenRefine/OpenRefine/releases) - [Commits](https://github.com/OpenRefine/OpenRefine/commits/3.8.1) --- updated-dependencies: - dependency-name: org.openrefine:main dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
| @@ -41,7 +41,7 @@ public FileRecordToRows(Iterator<FileRecord> iteratorFileRecords, boolean catego | |||
| this.identifierSpace = "https://commons.wikimedia.org/entity/"; | |||
| this.schemaSpace = "http://www.wikidata.org/prop/direct/"; | |||
| this.service = "https://commonsreconcile.toolforge.org/en/api"; | |||
| this.reconConfig = new StandardReconConfig(service, identifierSpace, schemaSpace, null, null, true, Collections.emptyList()); | |||
| this.reconConfig = new StandardReconConfig(service, identifierSpace, schemaSpace, null, null, true, relatedCategoriesIndex, Collections.emptyList(), relatedCategoriesIndex); | |||
There was a problem hiding this comment.
This looks like a default suggestion of your IDE, which used whatever integer was in scope to provide a missing integer parameter for the constructor - that can work for more complex types but it's rarely the right thing to do for basic types like integers. Specifically, those two integer parameters are:
- batchSize -> I would leave it to 10
- limit -> I would leave it to 0
There was a problem hiding this comment.
You're right. I was a bit quick to accept the suggestion. I found another constructor that didn't specify limit, giving it the default, so I used that one.
|
I tried with OR master (337d4e2) which works. At least the extension loads, though there was an error when I tried using it: a popup saying "Unable to parse preview". I haven't really used the extension so I don't know if it's related to this. The log reads:
|
|
According to the CI there is also a problem with Jackson, so it's probably worth doing the upgrade to Jackson 2.16.1 (to match the version used in OR 3.8.1) in the same go. |
|
I had a look and I think solving the build error (related to Jackson) will solve some (if not all of) the other errors you mentioned above. It looks like our test suite is proving somewhat useful! |
|
@dependabot rebase |
|
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
|
I rebased onto master and now have this error from test:
|
|
You should be able to rebase this PR by force-pushing to the remote (which you should be able to do even if you didn't create the branch / open the PR). Concerning the remaining error, this is something that seems to come from the way the test case only partially initializes OpenRefine, which was fine before but has been broken by a recent change in OpenRefine. Debugging this in my IDE, it seems that this is caused by the fact that |
Bumps org.openrefine:main from 3.6-SNAPSHOT to 3.8.1.
Release notes
Sourced from org.openrefine:main's releases.
... (truncated)
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)