Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactive rewrite #17

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open

Reactive rewrite #17

wants to merge 32 commits into from

Conversation

MoralCode
Copy link
Collaborator

@MoralCode MoralCode commented Nov 16, 2022

due to a specific issue( dotintent/FlutterBleLib#625) and apparrent lack of support or maintainence with the existing FlutterBleLib library, this pull request implements a small rewrite to swap this bluetooth backend with flutter_reactive_ble which seems to be maintained by Philips Hue.

Also we should give the documentation a quick once-over to make sure it represents the latest state of things:

  • inline documentation comments
  • README
    • content
    • demo app screenshots
  • repo wikis or any standalone docs in docs folders
    • DesignDecisions.md, bluetooth library section
    • internals.md, Internal API Design section is TBD

example/lib/main.dart Outdated Show resolved Hide resolved
example/lib/main.dart Outdated Show resolved Hide resolved
example/ios/Runner/Info.plist Outdated Show resolved Hide resolved
@MoralCode
Copy link
Collaborator Author

awesome, seems like its just looking over and fixing the documentation that's needed now. i made a bit of a checklist in the pull request to give a bit of an outline as to what documentation may be affected by this change

@MoralCode
Copy link
Collaborator Author

@Aldaniee ok, it looks like this should be all ready now - just updated a bunch of the docs. are you happy with the way the demo app works on iOS based on your testing? any other testing you want to do (or think needs to be done)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants