OVAL/sysctl: Fix offline mode #1996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rawhide failure is related to #1997 |
|
@evgenyz I think we need a test to avoid this situation. |
evgenyz
force-pushed
the
fix-sysctl-offline
branch
from
299e344
to
533e5f1
Compare
The initial implementation was buggy: after correctly traversing prefixed PREFIX/proc/sys directory tree it would incorrectly read the data from the non-prefixed directory tree.
evgenyz
force-pushed
the
fix-sysctl-offline
branch
from
533e5f1
to
7bf6811
Compare
I've updated the test to cover that scenario. |
jan-cerny
approved these changes
Sep 5, 2023
There was a problem hiding this comment.
I have run the test locally and I have deep dive into the OVAL results produced by the test test_sysctl_probe_offline_mode.sh In the OVAL results I have seen this item:
<system_data>
<unix-sys:sysctl_item id="1749992" status="exists">
<unix-sys:name>kernel.hostname</unix-sys:name>
<unix-sys:value>fake.host.name.me</unix-sys:value>
</unix-sys:sysctl_item>
</system_data>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial implementation was buggy: after correctly traversing prefixed PREFIX/proc/sys directory tree it would incorrectly read the data from the non-prefixed directory tree.