Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Request Modifications #304

Conversation

gonzalesedwin1123
Copy link
Member

@gonzalesedwin1123 gonzalesedwin1123 commented Jan 24, 2024

  • Allow targeting group/individual depending on the CR type
  • Add create new group CR

@gonzalesedwin1123 gonzalesedwin1123 linked an issue Jan 25, 2024 that may be closed by this pull request
3 tasks
@gonzalesedwin1123 gonzalesedwin1123 changed the title Change Request: Add Group Change Request Modifications Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 51 lines in your changes are missing coverage. Please review.

Comparison is base (4944222) 70.14% compared to head (0aec8fe) 69.96%.
Report is 2 commits behind head on 15.1.1-mono-repo.

❗ Current head 0aec8fe differs from pull request most recent head ef6d6e9. Consider uploading reports for the commit ef6d6e9 to get more accurate results

Files Patch % Lines
...quest_add_group/models/change_request_add_group.py 48.52% 35 Missing ⚠️
spp_change_request/models/change_request.py 28.57% 13 Missing and 2 partials ⚠️
...ls/change_request_add_group_validation_sequence.py 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##           15.1.1-mono-repo     #304      +/-   ##
====================================================
- Coverage             70.14%   69.96%   -0.18%     
====================================================
  Files                   437      447      +10     
  Lines                 11695    11840     +145     
  Branches               1551     1567      +16     
====================================================
+ Hits                   8203     8284      +81     
- Misses                 3152     3213      +61     
- Partials                340      343       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeremi
Copy link
Member

jeremi commented Feb 1, 2024

@gonzalesedwin1123 what is still needed on this PR?

@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2024
@gonzalesedwin1123 gonzalesedwin1123 deleted the 297-improve-change-requests-capabilities branch August 29, 2024 00:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve change requests capabilities
2 participants