Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Proloaf warning should only be raised if appropriate #278

Open
FrankKr opened this issue Jan 5, 2022 · 0 comments
Open

[chore] Proloaf warning should only be raised if appropriate #278

FrankKr opened this issue Jan 5, 2022 · 0 comments
Labels
chore Improvements or additions to documentation

Comments

@FrankKr
Copy link
Collaborator

FrankKr commented Jan 5, 2022

try:
from openstef.model.regressors.proloaf import OpenstfProloafRegressor
except ImportError:
logger.warning(
"Proloaf not available, switching to xgboost! See Readme how to install proloaf dependencies"
)
OpenstfProloafRegressor = XGBOpenstfRegressor

The warning that the optional proloaf dependency is not installed should only be raised if it is required. Currently it is always logged as a warning, causing for unneeded concern:
image

@FrankKr FrankKr added the chore Improvements or additions to documentation label Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant