Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove all proloaf references #517

Merged
merged 5 commits into from
Mar 27, 2024
Merged

remove all proloaf references #517

merged 5 commits into from
Mar 27, 2024

Conversation

FrankKr
Copy link
Collaborator

@FrankKr FrankKr commented Mar 27, 2024

Signed-off-by: FrankKr [email protected]

Fixes issue: #278 by removing all proloaf references since this model is not used and requires a lot of custom fixes.

@github-actions github-actions bot added the chore Improvements or additions to documentation label Mar 27, 2024
Copy link

sonarcloud bot commented Mar 27, 2024

Copy link
Collaborator

@JonitaRuiter JonitaRuiter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JonitaRuiter JonitaRuiter merged commit 1486c5d into main Mar 27, 2024
6 checks passed
@JonitaRuiter JonitaRuiter deleted the chore/remove-proloaf-#278 branch March 27, 2024 09:49
clara-de-smet pushed a commit that referenced this pull request Mar 27, 2024
* remove all proloaf references

Signed-off-by: FrankKr <[email protected]>

* Format Python code with Black

Signed-off-by: black <[email protected]>

* add optuna-integration

Signed-off-by: FrankKr <[email protected]>

* remove blank lines

Signed-off-by: FrankKr <[email protected]>

* improve datetime.now

Signed-off-by: FrankKr <[email protected]>

---------

Signed-off-by: FrankKr <[email protected]>
Signed-off-by: black <[email protected]>
Co-authored-by: black <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants