Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove incorrect report creation #472

Merged
merged 3 commits into from
Aug 14, 2023
Merged

Conversation

FrankKr
Copy link
Collaborator

@FrankKr FrankKr commented Aug 11, 2023

Verified locally that this solves the issue.
I did not add a unit test, since this involved retrieving data from the figure which can be done, but gets quite complex rather quickly.

@github-actions github-actions bot added the fix Something isn't working label Aug 11, 2023
Signed-off-by: Frank Kreuwel <[email protected]>
@FrankKr FrankKr requested a review from wfstoel August 11, 2023 15:11
Copy link
Collaborator

@JanMaartenvanDoorn JanMaartenvanDoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Added a minor suggestion.

Co-authored-by: Jan Maarten van Doorn <[email protected]>
Signed-off-by: Frank Kreuwel <[email protected]>
@FrankKr FrankKr merged commit 0783201 into main Aug 14, 2023
6 checks passed
@FrankKr FrankKr deleted the bugfix/KTPS-3012-validation-order branch August 14, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants