Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fix and unit test for detecting flatliners on prediction data w… #482

Merged
merged 5 commits into from
Nov 2, 2023

Conversation

bartpleiter
Copy link
Collaborator

…ith NaN load values in the future.

…ith NaN load values in the future.

Signed-off-by: Bart Pleiter <[email protected]>
…requirements to github unittest action.

Signed-off-by: Bart Pleiter <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Oct 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Collaborator

@wfstoel wfstoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of freezegun to make the unit test more stable!

@bartpleiter bartpleiter merged commit 25f965d into main Nov 2, 2023
7 checks passed
@bartpleiter bartpleiter deleted the bug/KTPS-3178-create_forecast-detect-flatliner branch November 2, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants