Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added suggestion to flatliner message. #486

Merged
merged 6 commits into from
Dec 11, 2023
Merged

Added suggestion to flatliner message. #486

merged 6 commits into from
Dec 11, 2023

Conversation

bartpleiter
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the chore Improvements or additions to documentation label Dec 8, 2023
MartijnCa
MartijnCa approved these changes Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@MartijnCa MartijnCa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good initiative to make these messages more clear!
I made suggestions in the comments to make them even more extensive and hopefully more clear as well.

openstef/tasks/create_forecast.py Outdated Show resolved Hide resolved
openstef/tasks/train_model.py Outdated Show resolved Hide resolved
test/unit/tasks/test_create_forecast.py Outdated Show resolved Hide resolved
test/unit/tasks/test_train_model.py Outdated Show resolved Hide resolved
bartpleiter and others added 5 commits December 11, 2023 08:53
@bartpleiter @MartijnCa
Update openstef/tasks/create_forecast.py
a2ae736 
Co-authored-by: Martijn Cazemier <[email protected]>
Signed-off-by: Bart Pleiter <[email protected]>
@bartpleiter @MartijnCa
Update openstef/tasks/train_model.py
cdb19fe 
Co-authored-by: Martijn Cazemier <[email protected]>
Signed-off-by: Bart Pleiter <[email protected]>
@bartpleiter @MartijnCa
Update test/unit/tasks/test_create_forecast.py
7c9398d 
Co-authored-by: Martijn Cazemier <[email protected]>
Signed-off-by: Bart Pleiter <[email protected]>
@bartpleiter @MartijnCa
Update test/unit/tasks/test_train_model.py
2f681c0 
Co-authored-by: Martijn Cazemier <[email protected]>
Signed-off-by: Bart Pleiter <[email protected]>
@bartpleiter
Format.
531c7d3 
Signed-off-by: Bart Pleiter <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bartpleiter bartpleiter merged commit 0e8560e into main Dec 11, 2023
7 checks passed
@bartpleiter bartpleiter deleted the chore/flatliner-message branch December 11, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartijnCa MartijnCa MartijnCa approved these changes

Assignees
No one assigned
Labels
chore Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartpleiter @MartijnCa