Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python-upload-package.yaml #491

Merged
merged 17 commits into from
Jan 10, 2024
Merged

Conversation

FrankKr
Copy link
Collaborator

@FrankKr FrankKr commented Jan 3, 2024

Uses improved method for publishing to pypi.

For future reference: https://docs.pypi.org/trusted-publishers/using-a-publisher/

->
The year change from 2023 to 2024 made it so that the feature engineering of holidays broke down.
Turns out that that part of the codebase is very messy and poorly (improperly) tested.
I made a story for improving that part seperately:
https://alliander.atlassian.net/browse/KTPS-3375

@github-actions github-actions bot added the chore Improvements or additions to documentation label Jan 3, 2024
Copy link
Collaborator

@bartpleiter bartpleiter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change to use gh action instead of twine

FrankKr and others added 16 commits January 8, 2024 14:34
Signed-off-by: Frank Kreuwel <[email protected]>
Signed-off-by: Frank Kreuwel <[email protected]>
Signed-off-by: Frank Kreuwel <[email protected]>
Signed-off-by: Frank Kreuwel <[email protected]>
Signed-off-by: Frank Kreuwel <[email protected]>
Signed-off-by: FrankKr <[email protected]>
Signed-off-by: FrankKr <[email protected]>
Signed-off-by: FrankKr <[email protected]>
Copy link

sonarcloud bot commented Jan 10, 2024

@FrankKr FrankKr merged commit 9dde174 into main Jan 10, 2024
6 checks passed
@FrankKr FrankKr deleted the chore/use-improved-pypi-publish-method branch January 10, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants