Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New dazls updates #492

Merged
merged 17 commits into from
Jan 16, 2024
Merged

New dazls updates #492

merged 17 commits into from
Jan 16, 2024

Conversation

ThomasNijsen
Copy link
Collaborator

Added a new DAZLs model (with license), and updated the DAZLs model class with a more elaborate string method for model checking.

Copy link
Collaborator

@wfstoel wfstoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job adding a new and better DAZLS model! I left some remarks for improvements regarding best practices.

.gitattributes Outdated Show resolved Hide resolved
openstef/pipeline/create_component_forecast.py Outdated Show resolved Hide resolved
openstef/pipeline/create_component_forecast.py Outdated Show resolved Hide resolved
openstef/data/dazls_stored_new_adaptation_model.z Outdated Show resolved Hide resolved
openstef/data/dazls_stored_new.sav.license Outdated Show resolved Hide resolved
Copy link
Collaborator

@wfstoel wfstoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link

sonarcloud bot commented Jan 16, 2024

@ThomasNijsen ThomasNijsen merged commit a5e9bba into main Jan 16, 2024
6 checks passed
@ThomasNijsen ThomasNijsen deleted the new_dazls_updates branch January 16, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants