Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New dazls updates #503

Merged
merged 32 commits into from
Feb 29, 2024
Merged

New dazls updates #503

merged 32 commits into from
Feb 29, 2024

Conversation

ThomasNijsen
Copy link
Collaborator

No description provided.

ThomasNijsen and others added 22 commits December 21, 2023 11:24
@ThomasNijsen
Updated the DAZLs model with a new string method to provide a summary…
de3ed89 
… of the model.
@ThomasNijsen
Added the new DAZLs model.
c07a632
@ThomasNijsen
Added the new DAZLs model liscence.
764704b
@actions-user
Format Python code with Black
0d4424f 
Signed-off-by: black <[email protected]>
@FrankKr
Update create_component_forecast.py
ee21a6d 
trigger new build

Signed-off-by: Frank Kreuwel <[email protected]>
@actions-user
Format Python code with Black
e782826 
Signed-off-by: black <[email protected]>
@ThomasNijsen
Added a requirement for the joblib package.
a8f7796 
Signed-off-by: thomasnijsen <[email protected]>
@ThomasNijsen
Removed previous dazls model.
c028e68 
Signed-off-by: thomasnijsen <[email protected]>
@ThomasNijsen
Added the new compressed dazls model.
19ff74e 
Signed-off-by: thomasnijsen <[email protected]>
@ThomasNijsen
Added the new DAZLs model in split form with changes to load it into …
90126c1 
…the pipeline.

Signed-off-by: thomasnijsen <[email protected]>
@actions-user
Format Python code with Black
6e380c2 
Signed-off-by: black <[email protected]>
@ThomasNijsen
Added in the changes that were noted during review.
0a4640f 
Signed-off-by: thomasnijsen <[email protected]>
@ThomasNijsen
Merge branch 'new_dazls_updates' of https://github.com/OpenSTEF/openstef
9158a7c 
 into new_dazls_updates
@actions-user
Format Python code with Black
f02e11f 
Signed-off-by: black <[email protected]>
@ThomasNijsen
Updated version number.
e3fade4 
Signed-off-by: thomasnijsen <[email protected]>
@ThomasNijsen
Merge branch 'new_dazls_updates' of https://github.com/OpenSTEF/openstef
6cd86f5 
 into new_dazls_updates
@ThomasNijsen
Updated package info.
4f83705 
Signed-off-by: Thomas Nijsen <[email protected]>
@ThomasNijsen
Resolved conflicts.
a76f962 
Signed-off-by: Thomas Nijsen <[email protected]>
@ThomasNijsen
Updated package data, stored old model in folders and adapted unit te…
3369d06 
…st path.

Signed-off-by: thomasnijsen <[email protected]>
@ThomasNijsen
Resolved conflicts.
0db858f 
Signed-off-by: thomasnijsen <[email protected]>
@ThomasNijsen
Updated dazls model for reduced size.
0556026 
Signed-off-by: thomasnijsen <[email protected]>
@ThomasNijsen
Updated dazls model with pipeline features.
72365ab 
Signed-off-by: Thomas Nijsen <[email protected]>
ThomasNijsen and others added 4 commits February 1, 2024 10:55
@ThomasNijsen
Merge branch 'main' into new_dazls_updates
dcccf91 
Signed-off-by: thomasnijsen <[email protected]>
@ThomasNijsen
Update requirements.txt
2335d81 
Signed-off-by: thomasnijsen <[email protected]>
@ThomasNijsen
Updated the DAZLs class documentation and added a convenience functio…
c3aeff2 
…n for predictions such that the submodels can be more easily investigated.

Signed-off-by: thomasnijsen <[email protected]>
@ThomasNijsen
Merge branch 'main' into new_dazls_updates
36b6fa2 
Signed-off-by: thomasnijsen <[email protected]>
wfstoel
wfstoel requested changes Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@wfstoel wfstoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see another iteration of the DAZLS model.

Could you remove all older versions of the DAZLS model from the git repo? The existence of these models makes the repo quite large.

openstef/model/regressors/dazls.py Outdated Show resolved Hide resolved
wfstoel
wfstoel approved these changes Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@wfstoel wfstoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
50.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ThomasNijsen ThomasNijsen removed the request for review from bartpleiter February 29, 2024 10:16
@ThomasNijsen ThomasNijsen merged commit 746b37b into main Feb 29, 2024
6 checks passed
@ThomasNijsen ThomasNijsen deleted the new_dazls_updates branch February 29, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wfstoel wfstoel wfstoel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ThomasNijsen @wfstoel @actions-user @FrankKr