Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated requirements.txt to use more permissive contraints for structlog. #511

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

egordm
Copy link
Collaborator

@egordm egordm commented Feb 29, 2024

Reason: Most of the internal packages such as logger require structlog 24 and up. The change allows openstef to be installed alongside those packages without conflicts.

Passed all tests.

@egordm egordm requested a review from wfstoel February 29, 2024 14:56
@github-actions github-actions bot added the fix Something isn't working label Feb 29, 2024
Copy link

sonarcloud bot commented Feb 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Collaborator

@wfstoel wfstoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@egordm egordm merged commit 93f3fc9 into main Mar 1, 2024
7 checks passed
@egordm egordm deleted the fix/requirements-structlog branch March 1, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants