Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General code improvements #527

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

General code improvements #527

wants to merge 5 commits into from

Conversation

wfstoel
Copy link
Collaborator

@wfstoel wfstoel commented Mar 27, 2024

No description provided.

wfstoel and others added 3 commits March 27, 2024 10:15
Copy link
Collaborator

@egordm egordm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small sugggestions

openstef/metrics/metrics.py Show resolved Hide resolved
test/unit/model/test_custom_models.py Show resolved Hide resolved
openstef/model/regressors/custom_regressor.py Show resolved Hide resolved
Signed-off-by: Willem Frederik Stoel <[email protected]>
Copy link
Collaborator

@egordm egordm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants