-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KTP-762 Implemented Linear Quantile Regression Model #529
Conversation
…issing values handler. Signed-off-by: Egor Dmitriev <[email protected]>
…ile regression model. Signed-off-by: Egor Dmitriev <[email protected]>
Signed-off-by: Egor Dmitriev <[email protected]>
c905ff9
to
c6c34db
Compare
Signed-off-by: Egor Dmitriev <[email protected]>
Signed-off-by: Egor Dmitriev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good Egor!
Two minor comments.
And if you are feeling clean-code-minded, you could solve the issues SonarCloud lists:
https://sonarcloud.io/project/issues?id=OpenSTEF_openstef&pullRequest=529&resolved=false&inNewCodePeriod=true
d5962cd
to
52f1fdf
Compare
…ed documentation for MissingValueTransformer and LinearQuantile. Applied code fix suggestions from Sonarcloud. Signed-off-by: Egor Dmitriev <[email protected]>
20f59c7
to
db10280
Compare
Signed-off-by: black <[email protected]>
Signed-off-by: Egor Dmitriev <[email protected]>
Quality Gate passedIssues Measures |
Following changes/features were added:
Notes:
Here are some insights from the comparison notebook:
Feature Importance
Feature importance is more balanced now, possibly also because of the feature filtering:
Model also sees that AMI, AZI etc features make a nice base signal.
Forecasting