Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X-Input Serial ID (Pico ID Based) #1235

Merged
merged 21 commits into from
Dec 23, 2024

Conversation

arntsonl
Copy link
Contributor

Update the X-input Serial ID to use the Pico unique ID instead of a static value.

This might affect multiple USB controllers plugged into the same computer, but it might not

ImgBotApp and others added 19 commits February 5, 2024 07:38
*Total -- 6,536.44kb -> 6,081.92kb (6.95%)

/configs/OpenCore0/assets/Open_Core0_LED_order.png -- 81.87kb -> 34.77kb (57.53%)
/configs/OpenCore0/assets/Open_Core0_pin_mapping.png -- 79.46kb -> 34.15kb (57.02%)
/configs/OpenCore0/assets/Open_Core0_layout.png -- 80.33kb -> 34.76kb (56.73%)
/configs/OpenCore0/assets/Open_Core0_2.jpg -- 3,134.92kb -> 2,976.17kb (5.06%)
/configs/OpenCore0/assets/Open_Core0.jpg -- 3,159.87kb -> 3,002.07kb (4.99%)

Signed-off-by: ImgBotApp <[email protected]>
[ImgBot] Optimize images
@Jimizan
Copy link

Jimizan commented Dec 16, 2024

without different GUID option (inside WEB CONFIGURATION) be a problem
randomly confuse the usb ports order
since one of the main uses and purchases of these encoders is for video games and 2 encoders are used...(2 players)...
they all have the same problem,...randomly the inputs of the 2 players are reversed in the program/game of use.
a big limit of the gp2040 with this use!

@arntsonl
Copy link
Contributor Author

without different GUID option (inside WEB CONFIGURATION) be a problem randomly confuse the usb ports order since one of the main uses and purchases of these encoders is for video games and 2 encoders are used...(2 players)... they all have the same problem,...randomly the inputs of the 2 players are reversed in the program/game of use. a big limit of the gp2040 with this use!

We took a look at how Batocera generates the GUID, and it appears to be based off of the VID/PID and not the reported serial ID. This should hopefully help Windows, but does not necessarily fix other distros.

This SHOULD help with https://github.com/MicrosoftDocs/windows-driver-docs/blob/staging/windows-driver-docs-pr/usbcon/selective-suspend-in-usb-drivers-wdf.md software based usb suspension. I've also verified in https://www.nirsoft.net/utils/usb_devices_view.html that both serials show up independently on two Pico devices.

@arntsonl arntsonl merged commit e2d765a into OpenStickCommunity:main Dec 23, 2024
44 checks passed
@arntsonl arntsonl deleted the 20241214_xinput_serial branch December 23, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants