Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize tag support #1525

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

gnydick
Copy link

@gnydick gnydick commented Feb 6, 2019

This new plugin type allows you to provide a plugin to normalize tags. My use case for implementing this is the fact that the slew of Cloud Native systems coming online all export their metrics slightly differently and opentsdb doesn't support fuzzy matches or specifying which tags are equivalent to each other.

I was receiving container, container-name, container_name, etc., etc., etc.

This plugin type requires a normalizeTags(tags) method. The tags are passed in and a normalized set are returned.

@@ -14,7 +14,7 @@
# along with this library. If not, see <http://www.gnu.org/licenses/>.

# Semantic Versioning (see http://semver.org/).
AC_INIT([opentsdb], [2.4.0], [[email protected]])
AC_INIT([opentsdb], [2.4.0-tnp], [[email protected]])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably don't need this change.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

@@ -12,59 +12,17 @@
// see <http://www.gnu.org/licenses/>.
package net.opentsdb.core;

import java.io.File;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, it looks like you did the "auto format" in IntelliJ, I've been tempted to commit this myself. Would it be possible to isolate just the changes relevant to your new plugin type?

I love the concept and would be happy to get this merged if we can remove the unrelated changes.

@@ -28,7 +28,7 @@
* after they are queued for storage. In the future we may support publishing
* meta data or other types of information as changes are made.
* <p>
* <b>Note:</b> Implementations must have a parameterless constructor. The
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can leave in all the "trailing whitespace" fixes if you want! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants