Reconstruct full GitHub URL for collections #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can safely convert between download URLs on GitHub and "full" URLs to the collection blob and its history. Addresses #871.
|
The simple fix above (munging the download URL) is working now on devtree. |
|
This is fine to me as a temporary solution. I've made a separate issue in peyotl for the question of having explicit view URLs for studies and collections. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can safely convert between a download URL on GitHub (currently provided as the collection's
external_url) and a "full" URL to the collection blob and its history. Addresses #871.N.B. that we might instead choose to redefine all "public" or "external" URLs in peyotl's documents, if we'd always prefer to show the richer GitHub view. Or we might distinguish between the two, if we can agree on suitable property names, perhaps
doc.download_url(looks like this) versusdoc.history_url(looks like this).