Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide both raw and view URLs for github studies / collections #149

Open
kcranston opened this issue Apr 18, 2016 · 2 comments
Open

Provide both raw and view URLs for github studies / collections #149

kcranston opened this issue Apr 18, 2016 · 2 comments
Labels
enhancement

Comments

@kcranston
Copy link
Member

See opentree issue #871. We've implemented a fix on the UI side for collections, but if we were going to provide similar 'view study in github' URLs (i.e. that point to the pretty github version rather than the raw version), would it make sense to have peyotl provide both a raw URL and view URL rather than hack the external_url property for the UI?
@kcranston kcranston mentioned this issue Apr 18, 2016
Merged
@jimallman
Copy link
Member

Agreed. I'm also pondering good general names to distinguish these:

  • history_url or github_url or repo_url for the full GitHub view?
  • download_url or view_url or raw_url for the "raw" latest version?

@jimallman
Copy link
Member

OK to close this? Or should we press on with uniform standards for "raw" and GitHub views of all resource types in peyotl?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mtholder @kcranston @jimallman