-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and simplify api urls #177
Conversation
Remove duplicate declarations and normalize whitespace.
re the 'IMPORTANT', since I'll probably be the one doing this, can you put
appropriate instructions in the config file itself? and what will be the
failure if I forget?
|
Compare the two linked config files (highlighted lines) to see the difference in
should become
Probably the simplest thing I can do is to duplicate these lines in the production file, make the desired changes, and comment them out. |
On second thought, the simplest thing is a (rare) pull request in deployed-systems, which should be merged only after this one. |
Good question. Some of these failures here can be pretty subtle, but the best "tell" will be lagging changes to studies in the index (oti). @jar398, how would you recommend running the unit tests in a way that takes into account the production config? The steps in TESTING.md seem a bit involved (installing peyotl, cloning repos, venv?) and not safe to do even on devapi. (Or am I mistaken, and I should simply run them on devapi within our usual venv?) |
Which TESTING.md are you talking about, germinator or phylesystem-api? Not I suppose we could collect all the tests in the germinator repo, so that I don't know about the peyotl dependency; it could be unnecessary, or easy Anyhow I can (& probably will) run the tests when I do the update, I On Mon, May 9, 2016 at 7:19 PM, Jim Allman [email protected] wrote:
|
Sorry, I meant the one in phlesystem-api. (I added a working hyperlink in a later edit.)
Thanks! I tried to test each URL in the system as it was changed. |
Support the new use of domain-only base URLs in system-config files. To do this, we tweak the internal definition of some API URLs to use the older, versioned URLs. This also modifies the on-commit webhook on GitHub.
Addresses #176. These changes are running now on devtree.
IMPORTANT: Once this PR is merged to master, we'll need to update the production api config file to match the domain-only base URLs used in devapi.