Send ga events for profile page #158
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbothma
reviewed
Jun 20, 2022
Comment on lines
+58
to
+70
| function sendAnalyticsEvent(category, action, label) { | ||
| // we use a timeout to ensure that the event is sent after user has | ||
| // scrolled over the element considerably | ||
| setTimeout(function () { | ||
| ga('send', { | ||
| hitType: 'event', | ||
| eventCategory: category, | ||
| eventAction: action, | ||
| eventLabel: label | ||
| }); | ||
| }, TIMEOUT_BEFORE_FIRING_ANALYTICS); | ||
| } | ||
|
|
There was a problem hiding this comment.
looks like this will send it 5s after it scroleld into view. I think what we wanted was to send if it was in view for 5s.
There was a problem hiding this comment.
this is the idea - cumulative is fine https://support.google.com/tagmanager/answer/7679410?hl=en#advanced
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send Google analytics events for the members' profile page