Added a mechanism to configure the HTML page title from the server #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfiguration Created a general.js setup page and move the analytics configuration there as well.
|
Deploy preview for wazimap-staging ready! Built with commit 84167ca |
milafrerichs
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created a general.js setup page and move the analytics configuration there as well.
Related Issue
#286
How to test it locally
added "page_title": "This is my title" into the profile configuration. You should see the change in the title of the page.
Screenshots
Changelog
Added
general.js to store page specific setup
Updated
Removed
Checklist
Pull Request
Code Quality
Testing