Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/ocp api #74

Merged
merged 2 commits into from
Jan 6, 2024
Merged

fix/ocp api #74

merged 2 commits into from
Jan 6, 2024

Conversation

NeonJarbas
Copy link
Contributor

@NeonJarbas NeonJarbas commented Jan 6, 2024

OCPInterface accidentally deleted some methods, this commit adds them back

adds OCPQuery bus api helper class

needs OpenVoiceOS/ovos-utils#215

OCPInterface accidentally deleted some methods, this commit adds them back

adds OCPQuery bus api helper class
@JarbasAl JarbasAl added the enhancement New feature or request label Jan 6, 2024
Copy link

codecov bot commented Jan 6, 2024

Codecov Report

Attention: 179 lines in your changes are missing coverage. Please review.

Comparison is base (863e711) 39.68% compared to head (9a83ba8) 36.01%.
Report is 2 commits behind head on dev.

❗ Current head 9a83ba8 differs from pull request most recent head 1830bd1. Consider uploading reports for the commit 1830bd1 to get more accurate results

Files Patch % Lines
ovos_bus_client/apis/ocp.py 0.00% 177 Missing ⚠️
ovos_bus_client/version.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #74      +/-   ##
==========================================
- Coverage   39.68%   36.01%   -3.68%     
==========================================
  Files          17       17              
  Lines        1726     1902     +176     
==========================================
  Hits          685      685              
- Misses       1041     1217     +176     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

OCPInterface accidentally deleted some methods, this commit adds them back

adds OCPQuery bus api helper class
@NeonJarbas NeonJarbas marked this pull request as ready for review January 6, 2024 01:08
@JarbasAl JarbasAl added the bug Something isn't working label Jan 6, 2024
@JarbasAl JarbasAl merged commit 376d7ea into OpenVoiceOS:dev Jan 6, 2024
5 checks passed
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants