-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📝 Add docstrings to stop
#644
Conversation
Docstrings generation was requested by @JarbasAl. * #643 (comment) The following files were modified: * `ovos_core/intent_services/__init__.py` * `ovos_core/intent_services/converse_service.py` * `ovos_core/intent_services/stop_service.py`
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
* fix:better_stop * requirements.txt * python versions * requirements.txt * 📝 Add docstrings to `stop` (#644) Docstrings generation was requested by @JarbasAl. * #643 (comment) The following files were modified: * `ovos_core/intent_services/__init__.py` * `ovos_core/intent_services/converse_service.py` * `ovos_core/intent_services/stop_service.py` Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix: stop DRY no need for 2 handlers, decrease complexity the only difference is an emitted event that is not listened too anywhere * requirements.txt * tests * tests * tests * tests --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Warning
The docstrings feature is in beta.
Docstrings generation was requested by @JarbasAl.
The following files were modified:
ovos_core/intent_services/__init__.py
ovos_core/intent_services/converse_service.py
ovos_core/intent_services/stop_service.py
These file types are not supported
.github/workflows/build_tests.yml
.github/workflows/coverage.yml
.github/workflows/pipaudit.yml
.github/workflows/sync_tx.yml
requirements/requirements.txt
ℹ️ Note