Language Module Factory Tests/Fixes #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #184 +/- ##
=====================================
Coverage ? 0.00%
=====================================
Files ? 57
Lines ? 3937
Branches ? 0
=====================================
Hits ? 0
Misses ? 3937
Partials ? 0 ☔ View full report in Codecov by Sentry. |
JarbasAl
reviewed
Oct 11, 2023
JarbasAl
reviewed
Oct 11, 2023
JarbasAl
reviewed
Oct 11, 2023
NeonDaniel
commented
Oct 11, 2023
Update config handling to special-case `translation_module` and `detection_module` Abstract default plugins to private variables for better testing/readability Relates to #182
NeonDaniel
force-pushed
the
FIX_LangFactoryPluginLoading
branch
from
ada5659 to
0b5269d
Compare
JarbasAl
reviewed
Oct 12, 2023
| @@ -99,6 +99,10 @@ def get_lang_detect_module_configs(module_name: str): | |||
| return load_plugin_configs(module_name, PluginConfigTypes.LANG_DETECT) | |||
|
|
|||
|
|
|||
| _fallback_lang_detect_plugin = "ovos-lang-detect-ngram-lm" | |||
There was a problem hiding this comment.
this can be updated later, merging for now
JarbasAl
approved these changes
Oct 12, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit tests to language factory methods
Update config handling to special-case
translation_moduleanddetection_moduleAbstract default plugins to private variables for better testing/readability
Relates to #182