Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elevate sound media role #201

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

emphasize
Copy link
Member

@emphasize emphasize commented Nov 7, 2023

This elevates the instant / queued sounds media role for pulse audio to audibly prioritize those sounds (ie. pulse ducking)

The set up of the ducking music role for those streams that should duck has to be taken care of seperately and is not part of this commit.

closes: OpenVoiceOS/ovos-audio#36

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 168 lines in your changes are missing coverage. Please review.

Comparison is base (8ef8580) 26.03% compared to head (5974b43) 29.96%.
Report is 69 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #201      +/-   ##
==========================================
+ Coverage   26.03%   29.96%   +3.93%     
==========================================
  Files          49       49              
  Lines        6376     6557     +181     
==========================================
+ Hits         1660     1965     +305     
+ Misses       4716     4592     -124     
Files Coverage Δ
ovos_utils/file_utils.py 56.08% <ø> (+10.05%) ⬆️
ovos_utils/system.py 48.16% <100.00%> (+4.78%) ⬆️
ovos_utils/version.py 0.00% <0.00%> (ø)
ovos_utils/__init__.py 49.58% <78.26%> (+6.72%) ⬆️
ovos_utils/skills/api.py 71.42% <60.00%> (+14.28%) ⬆️
ovos_utils/log.py 80.85% <0.00%> (-2.24%) ⬇️
ovos_utils/events.py 72.28% <77.77%> (+16.21%) ⬆️
ovos_utils/intents/intent_service_interface.py 43.04% <82.08%> (+26.43%) ⬆️
ovos_utils/gui.py 46.92% <78.12%> (+9.10%) ⬆️
ovos_utils/messagebus.py 30.28% <52.50%> (+3.62%) ⬆️
... and 2 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl added the bug Something isn't working label Nov 7, 2023
@JarbasAl JarbasAl requested a review from NeonDaniel November 7, 2023 19:29
@JarbasAl JarbasAl merged commit 5c05936 into OpenVoiceOS:dev Nov 8, 2023
6 of 10 checks passed
@github-actions github-actions bot mentioned this pull request Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The start/end_listening sounds should be called with the pulse media.role=phone to enable ducking
2 participants