Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: geolocation utils extracted from backend-client #296

Merged
merged 17 commits into from
Nov 19, 2024

coderabbit suggestions

f021340
Select commit
Loading
Failed to load commit list.
Merged

feature: geolocation utils extracted from backend-client #296

coderabbit suggestions
f021340
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 19, 2024 in 0s

45.72% (-1.48%) compared to 61dcb09

View this Pull Request on Codecov

45.72% (-1.48%) compared to 61dcb09

Details

Codecov Report

Attention: Patch coverage is 1.83486% with 107 lines in your changes missing coverage. Please review.

Project coverage is 45.72%. Comparing base (61dcb09) to head (f021340).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
ovos_utils/geolocation.py 0.00% 102 Missing ⚠️
ovos_utils/network_utils.py 28.57% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #296      +/-   ##
==========================================
- Coverage   47.19%   45.72%   -1.48%     
==========================================
  Files          31       32       +1     
  Lines        3244     3353     +109     
==========================================
+ Hits         1531     1533       +2     
- Misses       1713     1820     +107     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features: