-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: support newer pyee #303
Conversation
WalkthroughThe changes involve a modification to the import statement for Changes
Sequence Diagram(s)sequenceDiagram
participant Test as TestEventScheduler
participant Scheduler as EventScheduler
participant Emitter as ExecutorEventEmitter
Test->>Scheduler: Initialize EventScheduler
Scheduler->>Emitter: Schedule Event
Emitter-->>Scheduler: Event Scheduled
Test->>Scheduler: Validate Event Scheduling
Scheduler-->>Test: Return Validation Result
Warning Rate limit exceeded@mikejgray has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 14 minutes and 5 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
test/unittests/test_event_scheduler.py (1)
7-10
: Consider adding pyee version bounds in setup.py.To prevent future compatibility issues, it would be good to specify the supported pyee version range in setup.py.
Example:
install_requires=[ "pyee>=8.0.0,<10.0.0", # Adjust version bounds as needed ]
Summary by CodeRabbit
Bug Fixes
ExecutorEventEmitter
to ensure functionality even if the primary import fails.Tests
EventScheduler
andEventSchedulerInterface
functionalities.