-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configs(cpt): disable debug spec on cpt cfg #737
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But please let backend team to review this too.
Errr. It seems there is is something wrong.... |
5e2152c
to
c67a08d
Compare
Debug CSR has to remain, I have made a change that only disables sdtrig. |
c67a08d
to
8e1c77d
Compare
Generally LGTM. We may figure out why this decrease the performance greatly later. @wissygh Have you tried the generated checkpoints? Can these be used on XS successfully? @eastonman |
Trigger may cause breakpoint exception in nonDmode. |
mcontrol6 trigger checks every possible match, like PC, load addr or even load value. I think the implementation is not ideal, maybe skip matching earlier when the triggers are not enabled? @wissygh |
I have tested one ckpt on XiangShan with difftest, and it seems no problem. |
mcontrol6_trigger_check is consuming about 30% of the runtime, I think currently we don't need debug features on checkpoints.