Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configs(cpt): disable debug spec on cpt cfg #737

Merged
merged 1 commit into from
Jan 1, 2025

Conversation

eastonman
Copy link
Member

mcontrol6_trigger_check is consuming about 30% of the runtime, I think currently we don't need debug features on checkpoints.

Copy link
Member

@cebarobot cebarobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But please let backend team to review this too.

@cebarobot cebarobot self-requested a review December 24, 2024 15:06
@cebarobot
Copy link
Member

LGTM. But please let backend team to review this too.

Errr. It seems there is is something wrong....

@eastonman eastonman force-pushed the config-disable-debug-on-cpt branch from 5e2152c to c67a08d Compare December 24, 2024 15:06
@eastonman
Copy link
Member Author

Debug CSR has to remain, I have made a change that only disables sdtrig.

@eastonman eastonman force-pushed the config-disable-debug-on-cpt branch from c67a08d to 8e1c77d Compare December 24, 2024 15:12
@Tang-Haojin
Copy link
Member

Generally LGTM. We may figure out why this decrease the performance greatly later. @wissygh

Have you tried the generated checkpoints? Can these be used on XS successfully? @eastonman

@wissygh
Copy link
Contributor

wissygh commented Dec 25, 2024

Generally LGTM. We may figure out why this decrease the performance greatly later. @wissygh

Have you tried the generated checkpoints? Can these be used on XS successfully? @eastonman

Trigger may cause breakpoint exception in nonDmode.

@eastonman
Copy link
Member Author

mcontrol6 trigger checks every possible match, like PC, load addr or even load value. I think the implementation is not ideal, maybe skip matching earlier when the triggers are not enabled? @wissygh
This passes the zstd ckpt generate and restore CI. I think if the checkpoint can be restored on NEMU, it can be restored on XiangShan. @Tang-Haojin
I am now generating a suite of checkpoints using DeterLoad. I will report if any error occurs.

@eastonman
Copy link
Member Author

I have tested one ckpt on XiangShan with difftest, and it seems no problem.

@eastonman eastonman merged commit c627904 into master Jan 1, 2025
7 checks passed
@eastonman eastonman deleted the config-disable-debug-on-cpt branch January 1, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants