Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pseudo-fuzzing tests in hardhat in favor of foundry fuzzing. #4894

Open
Amxx opened this issue Feb 13, 2024 · 3 comments · May be fixed by #5095
Open

Remove pseudo-fuzzing tests in hardhat in favor of foundry fuzzing. #4894

Amxx opened this issue Feb 13, 2024 · 3 comments · May be fixed by #5095
Labels
idea tests Test suite and helpers.
Milestone
5.1

Comments

@Amxx
Copy link
Collaborator

Amxx commented Feb 13, 2024

Some unit tests are using loops generating random values. In some cases, this could be replaced with proper fuzzing. There are even cases where the fuzzing tests have already been written.

I propose we remove the random and/or looped unit tests when an equivalent fuzzing tests exists.
@Amxx Amxx added the tests Test suite and helpers. label Feb 13, 2024
@Amxx Amxx added this to the 5.1 milestone Feb 13, 2024
@Amxx Amxx added the idea label Feb 13, 2024
@allwin199
Copy link
Contributor

@Amxx If you are looking for someone to work on this. I would like to contribute.

@Amxx
Copy link
Collaborator Author

Amxx commented Feb 13, 2024

@allwin199 Thank you for the proposal.

We don't want to take any PR yet. You could help however by identifying tests that may be candidate for removal.

@allwin199
Copy link
Contributor

Sure!

@cairoeth cairoeth linked a pull request Jun 20, 2024 that will close this issue
Draft
15 tasks
@cairoeth cairoeth mentioned this issue Oct 15, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
idea tests Test suite and helpers.
Projects
None yet
Milestone
5.1
Development

Successfully merging a pull request may close this issue.

Add remaining fuzzing tests and remove pseudo-random fuzzing cairoeth/openzeppelin-contracts
2 participants
@Amxx @allwin199