Fuzz tampered tests for ERC2771Forwarder

[cairoeth]

Fixes #4896 and helps #4894

PR Checklist

• Tests
• Documentation
• Changeset entry (run npx changeset add)

[changeset-bot]

⚠️ No Changeset found

Latest commit: 1e2b9ce

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[ernestognw]

Leaving small nits since I'm still not convinced 100% of the Foundry tests. They're still good to go in case you decide to merge before 5.2

[Amxx]

this does not execute, it prepares a request, tampers it, and prepare the expected revert ... but it does not execute.

[cairoeth]

yeah i kinda meant for this function to generate a tampered execute, feel free to rename

[Amxx]

I'm getting

FAIL. Reason: unknown cheatcode with selector 0xd5bee9f5; you may have a mismatch between the `Vm` interface (likely in `forge-std`) and the `forge` version;

Is there a missing foundry update ?

[Amxx]

Why are testExecuteBatchTamperedValuesZeroReceiver and testExecuteBatchTamperedValues different?

One does _tamperedValues then expect a call, the other replace batchRequestDatas entirely and relies on the expectRevert in tamperedExecute.

I'd like to understand and clean all that, but I'm not able to run it locally :/

[cairoeth]

@Amxx those two functions are a bit different as they test for two different cases:

• testExecuteBatchTamperedValuesZeroReceiver: if the receiver is the zero address, then the call will revert if any of the meta transactions are invalid/tampered
• testExecuteBatchTamperedValues: if the receiver is not the zero address, then the call will not revert but the tampered meta transaction will simply just be skipped.

To get the latest version and be able to run the tests, do foundryup on terminal.

[Amxx]

@cairoeth I rewrote the test quite heavily. IMO that is more readable. Let me know what you think.

[cairoeth]

looks great, thanks!