-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Memory
utility library
#5189
base: master
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 1aae8bb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
||
/// @dev Memory utility library. | ||
library Memory { | ||
type Pointer is bytes32; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we call that type type FMP is bytes32;
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be better with FreePointer
as FMP
is not obvious at first.
EDIT: Acutally I do prefer just Pointer
, since it's not always the free memory pointer. Anyone can get a point to wherever they want with asPointer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would we rename the getFreePointer
and setFreePointer
to getFreeMemoryPointer
and setFreeMemoryPointer
?
IMO this PR should include the usage of this lib |
Co-authored-by: Hadrien Croubois <[email protected]>
Picked from #5094
PR Checklist
npx changeset add
)