This repository has been archived by the owner on Jan 24, 2022. It is now read-only.
Migrate encodeCall.ts to web3 per comment #1166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
required removal of tests where unsigned ints were expected to fail if given negative numbers, because web3 wraps such numbers around.
|
Thanks for the contribution, @CallMeGwei! We'll review this in a few days :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a comment at the top of helper encodeCall.ts about migrating to web3. I went ahead and migrated it for my own project. Thought I would submit it here as well.
Web3 handles encoding parameters just a little differently than what was being used before. Web3 wraps around if given a negative for type uint rather than throwing. It also appears to convert empty buffers to nulls rather than keeping them as empty buffers. I had to tweak the test file accordingly.
I also added a helper function in the test to convert from the web3 return value (which is an object) to what was expected in the asserts (which was an array).