This repository has been archived by the owner on Jan 24, 2022. It is now read-only.
Add async option for send-tx command #1532
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalladino
reviewed
May 4, 2020
| @@ -31,3 +31,7 @@ program.Command.prototype.withNonInteractiveOption = function(): Command { | |||
| program.Command.prototype.withSkipCompileOption = function(): Command { | |||
| return this.option('--skip-compile', 'skips contract compilation'); | |||
| }; | |||
|
|
|||
| program.Command.prototype.withAsyncOption = function(): Command { | |||
| return this.option('--async-tx', 'avoid waiting for tx gets mined'); | |||
There was a problem hiding this comment.
Suggested change
| return this.option('--async-tx', 'avoid waiting for tx gets mined'); | |
| return this.option('--async-tx', 'do not wait for the transaction to be mined'); |
spalladino
suggested changes
May 4, 2020
There was a problem hiding this comment.
Thanks for the PR @k06a! I'd expect the async-tx option to await for the tx to be sent, if not mined. Removing the await altogether could mean that any errors in sending the tx may be lost, since the CLI does not wait for the HTTP request to the node to return. Also, the CLI should show the tx hash in the console, so the user can follow up on it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1531