Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ERC1155 #275

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

programskillforverification
Copy link

@programskillforverification programskillforverification commented Sep 4, 2024

Resolves #261

PR Checklist

  • ERC1155
  • Extensions
  • Tests
  • Documentation

Copy link

netlify bot commented Sep 4, 2024

Deploy Preview for contracts-stylus ready!

Name Link
🔨 Latest commit dd932cd
🔍 Latest deploy log https://app.netlify.com/sites/contracts-stylus/deploys/66eeb4ccd4fcb300088ec44c
😎 Deploy Preview https://deploy-preview-275--contracts-stylus.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are doing great job @programskillforverification! 🚀
The structure and design look good.

Remember to add antora docs as here - https://github.com/OpenZeppelin/rust-contracts-stylus/tree/v0.1.0/docs/modules/ROOT/pages

examples/erc1155/Cargo.toml Outdated Show resolved Hide resolved
// SPDX-License-Identifier: MIT
pragma solidity ^0.8.21;

contract Erc1155Example {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip: make sure to apply same memory structure as for example of ERC-1155

Cargo.toml Outdated Show resolved Hide resolved
contracts/src/token/erc1155/extensions/burnable.rs Outdated Show resolved Hide resolved
contracts/src/token/erc1155/mod.rs Outdated Show resolved Hide resolved
contracts/src/token/erc1155/mod.rs Outdated Show resolved Hide resolved
contracts/src/token/erc1155/mod.rs Outdated Show resolved Hide resolved
contracts/src/token/erc1155/mod.rs Outdated Show resolved Hide resolved
contracts/src/token/erc1155/mod.rs Show resolved Hide resolved
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 17.21311% with 303 lines in your changes missing coverage. Please review.

Project coverage is 79.3%. Comparing base (d4f57e6) to head (0188be0).

Files with missing lines Patch % Lines
contracts/src/token/erc1155/mod.rs 18.9% 269 Missing ⚠️
...tracts/src/token/erc1155/extensions/uri_storage.rs 0.0% 34 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...tracts/src/token/erc1155/extensions/uri_storage.rs 0.0% <0.0%> (ø)
contracts/src/token/erc1155/mod.rs 18.9% <18.9%> (ø)

... and 12 files with indirect coverage changes

@programskillforverification
Copy link
Author

You are doing great job @programskillforverification! 🚀 The structure and design look good.

Remember to add antora docs as here - https://github.com/OpenZeppelin/rust-contracts-stylus/tree/v0.1.0/docs/modules/ROOT/pages

Thanks for your review, I will fix all asap

@leeederek
Copy link

A developer is asking for an ERC1155 Stylus Rust implementation in @arbitrum_stylus TG chat.

@erayack
Copy link

erayack commented Sep 17, 2024

A developer is asking for an ERC1155 Stylus Rust implementation in @arbitrum_stylus TG chat.

Would love to hear some expected timelines but I could still use this as inspiration for my own implementation.

@programskillforverification
Copy link
Author

@bidzyyys is ERC1155 Stylus Rust implementation urgent? If so, I would to try the best finish all but antora docs by this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: ERC1155
4 participants