Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(e2e): deploy contracts without Solidity constructor when not needed #295

Merged
merged 5 commits into from
Sep 23, 2024
Merged

fix(e2e): deploy contracts without Solidity constructor when not needed #295

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7943267
chore: add possibility of deploying contracts without constructor thr…
TucksonDev Sep 20, 2024
f6ad977
Remove ecdsa constructor
TucksonDev Sep 20, 2024
4ca5138
Merge branch 'main' into add-e2e-deployment-without-constructor
bidzyyys Sep 21, 2024
81f2797
Format
TucksonDev Sep 22, 2024
a9cdbd3
fix fmt
qalisander Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions examples/ecdsa/src/constructor.sol
View file
Open in desktop

This file was deleted.

8 changes: 7 additions & 1 deletion lib/e2e/src/deploy.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
use std::path::Path;
use alloy::{rpc::types::TransactionReceipt, sol_types::SolConstructor};
use koba::config::Deploy;

Expand Down Expand Up @@ -45,11 +46,16 @@ impl Deployer {
let pkg = Crate::new()?;
let wasm_path = pkg.wasm;
let sol_path = pkg.manifest_dir.join("src/constructor.sol");
let sol = if Path::new(&sol_path).exists() {
Some(sol_path)
} else {
None
};

let config = Deploy {
generate_config: koba::config::Generate {
wasm: wasm_path.clone(),
sol: Some(sol_path),
sol,
args: self.ctr_args,
legacy: false,
},
Expand Down
Loading