Read paella json data properly from mod #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluetom
approved these changes
Jan 14, 2025
bluetom
pushed a commit
that referenced
this pull request
Jan 16, 2025
* Fixes #54 * read paella json data properly from mod, (#57) fixes #56 * Use Opencast PHP Library for api call Change error message * make sure lti launch gets a proper base url in both allinone and multi-nodes opencast instances * change the service to search and make sure it is active * get rid of services --------- Co-authored-by: FarbodZamani <[email protected]> Co-authored-by: ferishili <[email protected]>
bluetom
added a commit
that referenced
this pull request
Jan 16, 2025
* Fixes #54 * read paella json data properly from mod, (#57) fixes #56 * Use Opencast PHP Library for api call Change error message * make sure lti launch gets a proper base url in both allinone and multi-nodes opencast instances * change the service to search and make sure it is active * get rid of services --------- Co-authored-by: elke-hsh <[email protected]> Co-authored-by: FarbodZamani <[email protected]> Co-authored-by: ferishili <[email protected]>
bluetom
added a commit
that referenced
this pull request
Jan 17, 2025
* Fixes #54 (#55) * Fixes #54 * read paella json data properly from mod, (#57) fixes #56 * Use Opencast PHP Library for api call Change error message * make sure lti launch gets a proper base url in both allinone and multi-nodes opencast instances * change the service to search and make sure it is active * get rid of services --------- Co-authored-by: FarbodZamani <[email protected]> Co-authored-by: ferishili <[email protected]> * version.php changelog readme * moodle release change branch to main --------- Co-authored-by: elke-hsh <[email protected]> Co-authored-by: FarbodZamani <[email protected]> Co-authored-by: ferishili <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #56,
We already updated the mod plugin to provide a proper error message handling and forgot to update the way that the data is not being returned, therefore here is an update to read the paella json data properly from mod plugin!