Fix error notification (#51)

* Fix error notification The error notification is shown if two or more streams are available, but it should only be displayed if there are no streams. * code improvements --------- Co-authored-by: ferishili <[email protected]>
Opencast-Moodle · Dec 1, 2024 · 89dbe1a · 89dbe1a
1 parent cf7e231
commit 89dbe1a
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/classes/local/output_helper.php b/classes/local/output_helper.php
@@ -135,16 +135,17 @@ public static function output_episode($ocinstanceid, $episodeid, $modinstanceid,
             return;
         }
 
-        // Find aspect-ratio if there is only one video track.
-        if (count($data['streams']) === 1 && !empty($data['streams'][0]['sources'])) {
+        // Find aspect-ratio of the first video track.
+        $wrapperattrs = [];
+        if (!empty($data['streams']) && !empty($data['streams'][0]['sources'])) {
             $sources = $data['streams'][0]['sources'];
             $res = $sources[array_key_first($sources)][0]['res'];
             $resolution = $res['w'] . '/' . $res['h'];
-            echo \html_writer::start_div('player-wrapper', ['style' => '--aspect-ratio:' . $resolution]);
-        } else {
-            echo \html_writer::start_div('player-wrapper');
+            $wrapperattrs['style'] = '--aspect-ratio:' . $resolution;
         }
 
+        echo \html_writer::start_div('player-wrapper', $wrapperattrs);
+
         echo '<iframe src="player.html" id="player-iframe" class="mod-opencast-paella-player" allowfullscreen"></iframe>';
         echo \html_writer::end_div();