Upgrade Opencast PHP Library to 1.8.0 + Api Version setting (OC 16 Su…

…pport) + Moodle 4.4 Required Changes (#63)

* upgrade oc-php-lib to 1.8.0

* add api version setting

* code checker mdl 4.4

* code checker lang sort part 2

* remove platform checker for php < 8.1

* revert api version setting

---------

Co-authored-by: Thomas Niedermaier <[email protected]>

classes/local/api_testable.php

@@ -43,7 +43,7 @@ class api_testable extends api {
     private $httpcode;
 
     /** @var string version api version to apply for */
-    public $version = '1.9.0';
+    public $version = '1.10.0';
 
     /** @var string the username. */
     private string $username;

classes/local/environment_util.php

@@ -16,8 +16,6 @@
 
 namespace tool_opencast\local;
 
-defined('MOODLE_INTERNAL') || die;
-
 /**
  * An environment util for the Opencast Moodle plugins.
  *

classes/privacy/provider.php

@@ -13,6 +13,7 @@
 //
 // You should have received a copy of the GNU General Public License
 // along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
+
 /**
  * Privacy Subsystem implementation for tool opencast.
  *

composer.json

@@ -1,6 +1,9 @@
 {
     "name": "moodle/tool_opencast",
-    "require-dev": {
-        "elan-ev/opencast-api": "^1.5"
+    "require": {
+        "elan-ev/opencast-api": "1.8"
+    },
+    "config": {
+        "platform-check": false
     }
 }

db/services.php

@@ -13,13 +13,15 @@
 //
 // You should have received a copy of the GNU General Public License
 // along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
+
 /**
  * Services for the Opencast API.
  *
  * @package tool_opencast
  * @copyright 2018 Tobias Reischmann <[email protected]>
  * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
+
 defined('MOODLE_INTERNAL') || die();
 
 $functions = [

lang/en/tool_opencast.php

@@ -25,10 +25,9 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-$string['pluginname'] = 'Opencast API';
 $string['addinstance'] = 'Add instance';
-$string['apicreadentialstestfailedlong'] = 'The given Username or Password for the Opencast API is not valid.<br />Please use valid Username and Password in order to avoid fatal error during tasks which use this setting.';
 $string['apicreadentialstestfailedshort'] = 'Opencast API User Credentials test failed with http code: {$a}';
+$string['apicreadentialstestfailedlong'] = 'The given Username or Password for the Opencast API is not valid.<br />Please use valid Username and Password in order to avoid fatal error during tasks which use this setting.';
 $string['apicreadentialstestsuccessfulshort'] = 'Opencast API User Credentials test successful.';
 $string['apipassword'] = 'Password of Opencast API user';
 $string['apipassworddesc'] = 'Configure the password of the Opencast user who is used to do the Opencast API calls.';
@@ -69,6 +68,7 @@
 $string['opencast:externalapi'] = 'Access to Opencast API webservices';
 $string['opencast:instructor'] = 'Gives the role of an instructor in Opencast';
 $string['opencast:learner'] = 'Gives the role of a learner in Opencast';
+$string['pluginname'] = 'Opencast API';
 $string['privacy:metadata'] = 'The Opencast API admin tool only provides API endpoints and general settings for the set of Opencast plugins. It stores which Opencast series belongs to which Moodle course, but it does not store any personal data.';
 $string['serverconnectionerror'] = 'There was a problem with the connection to the Opencast server. Please check your Opencast API credentials and your network settings.';
 $string['testtooldisabledbuttontitle'] = 'Unable to conduct the connection test due to unloaded js modules.';

thirdpartylibs.xml

@@ -10,7 +10,7 @@
     <library>
         <location>vendor/elan-ev/opencast-api</location>
         <name>Opencast PHP Library</name>
-        <version>1.3</version>
+        <version>1.8</version>
         <license>GPL</license>
         <licenseversion>3.0-or-later</licenseversion>
     </library>

vendor/autoload.php

@@ -2,6 +2,24 @@
 
 // autoload.php @generated by Composer
 
+if (PHP_VERSION_ID < 50600) {
+    if (!headers_sent()) {
+        header('HTTP/1.1 500 Internal Server Error');
+    }
+    $err = 'Composer 2.3.0 dropped support for autoloading on PHP <5.6 and you are running '.PHP_VERSION.', please upgrade PHP or use Composer 2.2 LTS via "composer self-update --2.2". Aborting.'.PHP_EOL;
+    if (!ini_get('display_errors')) {
+        if (PHP_SAPI === 'cli' || PHP_SAPI === 'phpdbg') {
+            fwrite(STDERR, $err);
+        } elseif (!headers_sent()) {
+            echo $err;
+        }
+    }
+    trigger_error(
+        $err,
+        E_USER_ERROR
+    );
+}
+
 require_once __DIR__ . '/composer/autoload_real.php';
 
 return ComposerAutoloaderInit8ba2ca4e105ea351f7cb241590a7de7e::getLoader();