Skip to content

Commit

Permalink
fix(opentrons-ai-client): fix build error for staging (#15334)
Browse files Browse the repository at this point in the history
* fix(opentrons-ai-client): fix build error for staging
  • Loading branch information
koji authored Jun 5, 2024
1 parent 2143feb commit 366e223
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/opentrons-ai-production-deploy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:
make setup-js
- name: 'build'
run: |
make -C opentrons-ai-client build
make -C opentrons-ai-client build-production
- name: Configure AWS Credentials
uses: aws-actions/configure-aws-credentials@v4
with:
Expand Down
18 changes: 10 additions & 8 deletions opentrons-ai-client/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,14 @@ tests ?=
cov_opts ?= --coverage=true
test_opts ?=

# This variable is for all command
target ?= production

# standard targets
#####################################################################

.PHONY: all
all: clean build
all: clean build-$(target)

.PHONY: setup
setup:
Expand All @@ -34,16 +37,15 @@ clean:
# artifacts
#####################################################################

.PHONY: build
build: export NODE_ENV := production
build:
.PHONY: build-production
build-production: export NODE_ENV := production
build-production:
vite build
git rev-parse HEAD > dist/.commit


.PHONY: build-staging
build: export NODE_ENV := staging
build:
build-staging: export NODE_ENV := staging
build-staging:
vite build
git rev-parse HEAD > dist/.commit

Expand Down Expand Up @@ -75,4 +77,4 @@ staging-deploy:

.PHONY: prod-deploy
prod-deploy:
aws s3 sync ./dist s3://prod-opentrons-ai-front-end/ --delete
aws s3 sync ./dist s3://prod-opentrons-ai-front-end/ --delete

0 comments on commit 366e223

Please sign in to comment.