dont use make to switch into ll directory

Opentrons · Oct 3, 2024 · 907da5e · 907da5e
1 parent 5932ab5
commit 907da5e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 10 deletions.
diff --git a/.github/workflows/ll-test-build-deploy.yaml b/.github/workflows/ll-test-build-deploy.yaml
@@ -115,10 +115,11 @@ jobs:
           yarn config set cache-folder ./.yarn-cache
           make setup-js
       - name: 'test-e2e'
+        working-directory: labware-library
         env:
           OT_LL_MIXPANEL_ID: ${{ secrets.OT_LL_MIXPANEL_ID }}
           OT_LL_MIXPANEL_DEV_ID: ${{ secrets.OT_LL_MIXPANEL_DEV_ID }}
-        run: make -C labware-library test-e2e
+        run: make labware-library test-e2e
   build-ll:
     name: 'build labware library artifact'
     needs: ['js-unit-test']

diff --git a/labware-library/cypress.config.js b/labware-library/cypress.config.js
@@ -9,6 +9,5 @@ module.exports = defineConfig({
       return require('./cypress/plugins/index.js')(on, config)
     },
     baseUrl: 'http://localhost:5179',
-    downloadsFolder: 'cypress/downloads',
   },
 })
diff --git a/labware-library/cypress/plugins/index.js b/labware-library/cypress/plugins/index.js
@@ -16,13 +16,8 @@
 /**
  * @type {Cypress.PluginConfig}
  */
+// eslint-disable-next-line no-unused-vars
 module.exports = (on, config) => {
-  on('before:browser:launch', (browser = {}, launchOptions) => {
-    if (browser.name === 'chrome') {
-      launchOptions.preferences.default.download = {
-        default_directory: config['downloadsFolder'].replace(/\\/g, '\\\\'),
-      }
-      return launchOptions
-    }
-  })
+  // `on` is used to hook into various events Cypress emits
+  // `config` is the resolved Cypress config
 }