Skip to content

Commit

Permalink
add timeout to cypress compute spinner assertion
Browse files Browse the repository at this point in the history
  • Loading branch information
shlokamin committed Dec 14, 2023
1 parent d5f3729 commit ff7e4d9
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion protocol-designer/cypress/integration/migrations.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,8 @@ describe('Protocol fixtures migrate and match snapshots', () => {
mimeType: 'application/json',
encoding: 'utf8',
})
cy.get('[data-test="ComputingSpinner"]').should('exist')
cy.get('[data-test="ComputingSpinner"]'),

Check failure on line 95 in protocol-designer/cypress/integration/migrations.spec.js

View workflow job for this annotation

GitHub Actions / js checks

Expected an assignment or function call and instead saw an expression

Check failure on line 95 in protocol-designer/cypress/integration/migrations.spec.js

View workflow job for this annotation

GitHub Actions / js checks

Unexpected use of comma operator

Check failure on line 95 in protocol-designer/cypress/integration/migrations.spec.js

View workflow job for this annotation

GitHub Actions / js checks

Expected an assignment or function call and instead saw an expression

Check failure on line 95 in protocol-designer/cypress/integration/migrations.spec.js

View workflow job for this annotation

GitHub Actions / js checks

Unexpected use of comma operator
{ timeout: 5000 }.should('exist')
// wait until computation is done before proceeding, with generous timeout
cy.get('[data-test="ComputingSpinner"]', { timeout: 30000 }).should(
'not.exist'
Expand Down

0 comments on commit ff7e4d9

Please sign in to comment.