Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(api): only ignore stalls for downward portion of force pickup routine #14725

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

caila-marashaj
Copy link
Contributor

@caila-marashaj caila-marashaj commented Mar 25, 2024

Overview

During force tip-pickup, the z stage ignores stalls for all parts of the movement, including when it retracts back up towards the home position. This is believed to be the cause of some 'unknown position' problems popping in testing, so this changes the code to only ignore stalls during the parts of the routine that are actually pushing into the tiprack.

Changelog

  • make ignoring stalls during the pickup routine conditional on the direction of movement
  • change the target_down variable to target for readability purposes

@caila-marashaj caila-marashaj requested a review from a team as a code owner March 25, 2024 15:15
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.19%. Comparing base (8f50b08) to head (0ae7ba3).
Report is 54 commits behind head on edge.

❗ Current head 0ae7ba3 differs from pull request most recent head ae3eb1f. Consider uploading reports for the commit ae3eb1f to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #14725      +/-   ##
==========================================
- Coverage   67.50%   67.19%   -0.32%     
==========================================
  Files        2521     2495      -26     
  Lines       72090    71563     -527     
  Branches     9311     9076     -235     
==========================================
- Hits        48666    48088     -578     
- Misses      21228    21330     +102     
+ Partials     2196     2145      -51     
Flag Coverage Δ
g-code-testing 92.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
api/src/opentrons/hardware_control/ot3api.py 79.55% <ø> (ø)

... and 126 files with indirect coverage changes

Copy link
Contributor

@ahiuchingau ahiuchingau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - LGTM once tested on the FLEX!

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, good once tested on a flex

@caila-marashaj caila-marashaj merged commit 35e9fe7 into edge Apr 16, 2024
24 of 29 checks passed
@caila-marashaj caila-marashaj deleted the RABR-195-force-pickup-refactor branch April 16, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants