fix(modules): use parse from packaging module #14732
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #14732 +/- ##
==========================================
+ Coverage 67.17% 67.19% +0.02%
==========================================
Files 2495 2495
Lines 71483 71403 -80
Branches 9020 8992 -28
==========================================
- Hits 48020 47982 -38
+ Misses 21341 21305 -36
+ Partials 2122 2116 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -16,6 +15,14 @@ | |||
| TaskPayload = TypeVar("TaskPayload") | |||
|
|
|||
|
|
|||
| def parse_fw_version(version: str) -> Version: | |||
There was a problem hiding this comment.
What is the difference when using parse instead of instantiating a Version object directly?
The answer is nothing, absolutely nothing.
https://github.com/pypa/packaging/blob/main/src/packaging/version.py#L47-L56
It is for backward compatibility when parse used to return a Version or a LegacyVersion object
There was a problem hiding this comment.
yeah, I was mostly using it here to detect a bad version name so we can default it to 0.0.0
There was a problem hiding this comment.
No, your function is totally good. What I mean is all packaging.version.parse(string_version) does is call Version(string_version) under the hood. Ignore me lol
| ["v3.0.dshjfd", Version("v0.0.0")], | ||
| ], | ||
| ) | ||
| async def test_catch_invalid_fw_version( |
There was a problem hiding this comment.
this should be next to the actual code it's testing
caila-marashaj
force-pushed
the
RQA-2303-handle-unexpected-mod-fw-name
branch
from
c11b186
to
bcf9f53
Compare
Fix for #14712.
We were using parse_version from
pkg_resources,which can raise anInvalidVersionError, and importingInvalidVersionErrorfrom a separate packaging module. This imports theparsefunction from the same module the error would be raised from.