Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update vite version 5.3.2 #15739

Merged
merged 14 commits into from
Sep 30, 2024
Merged

chore: update vite version 5.3.2 #15739

merged 14 commits into from
Sep 30, 2024

Conversation

koji
Copy link
Contributor

@koji koji commented Jul 22, 2024

Overview

update vite version v5.3.2 and shx to v0.3.4
close AUTH-575

PD is using a few packages that have issues with mjs. This will be fixed in the future.

ToDo

update plugins

  • tbd
  • update vite.config.ts

check make commands

  • make -C app dev
  • make -C app dev-odd
  • make -C app-shell-odd push-ot3 host=
  • make -C components dev
  • make -C protocol-designer dev
  • make -C labware-library dev
  • make -C labware-designer dev
  • make -C opentrons-ai-client dev
  • make test-js
  • make check-js
  • make lint-js
  • make -C app-shell-odd

cjs

https://vitejs.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated
vite.config.ts -> vite.config.mts
https://opentrons.slack.com/archives/C6PF2M2LC/p1721746824847409

For vitest, the required updates will be done another PR, #15687

bonus

we can use a VSCode plugin to run test code from VSCode

Test Plan

  1. run make teardown-js && make setup-js
  2. check that the above commands work

when you run a project, there is no waring message except for protocol-designer

Screenshot 2024-09-27 at 11 52 45 AM

Screenshot 2024-09-27 at 11 52 56 AM

Changelog

Review requests

Risk assessment

should be low

@koji koji marked this pull request as ready for review August 8, 2024 23:25
@koji koji requested review from a team as code owners August 8, 2024 23:25
@koji koji requested review from smb2268, a team and TamarZanzouri and removed request for a team, smb2268 and TamarZanzouri August 8, 2024 23:25
@koji koji marked this pull request as draft August 9, 2024 01:16
@koji koji marked this pull request as ready for review August 9, 2024 01:35
@koji koji changed the title chore: update vite version chore: update vite version 5.4.8 Sep 30, 2024
@koji koji changed the title chore: update vite version 5.4.8 chore: update vite version 5.3.2 Sep 30, 2024
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - let's merge and get some builds out and tested. we can always revert if we need

@koji koji merged commit f4056d0 into edge Sep 30, 2024
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants